Input Event broke my animation of player cause crash for walk and run cicles

Question

When i pressed KEY_UP play action animation of a player but cause crash if you continue pressed in this case is for running.

func ready():
setprocess(true)
getnode("SpatialPlayer/AnimationPlayer").play("playerstopwithanimgun")
getnode("SpatialPlayer/AnimationPlayer").setspeed(0.2)
setprocess_input(true)

func _process(delta):
pass

func input(event):
if (event.type==InputEvent.KEY and event.scancode == KEYUP and event.pressed):
getnode("SpatialPlayer/AnimationPlayer").play("running")
getnode("SpatialPlayer/AnimationPlayer").setspeed(0.5)
else:
getnode("SpatialPlayer/AnimationPlayer").play("playerstopwithanimgun")
getnode("SpatialPlayer/AnimationPlayer").setspeed(0.2)

I need with key_UP pressed animation continue in loop without crash

Any ideia to solve this?

Answer 1

I would try something like this for your check:

if event.type==InputEvent.KEY and event.scancode == KEYUP and not event.echo:
    if event.pressed:
        getnode("SpatialPlayer/AnimationPlayer").play("running")
        getnode("SpatialPlayer/AnimationPlayer").setspeed(0.5)
    else:
        getnode("SpatialPlayer/AnimationPlayer").play("playerstopwithanimgun")
        getnode("SpatialPlayer/AnimationPlayer").setspeed(0.2)

The only code I added was "not event.echo." This will ignore continuous press events, which is actually what you want. Now, when KEYUP is pressed, the first "if" condition will happen. When KEYUP is let go, the second "if" condition will play.

As for why your program crashed, my guess is that your "if" statement runs the second condition for all events that aren't a KEYUP press. There are a lot of them. To see that, add this line to the beginning of your input function:

print(event)

You will see a ton of events written to the console. Each time, your second "if" condition happened.

Comments

not work that

I just declare two variables in main scene and solve that

func ready():
setfixedprocess(true)
# variable for check Node control of Animatios
animplayer = getnode("SpatialPlayer/AnimationPlayer")

   set_process_input(true)

func fixedprocess(delta):
if (anim != animnew):
animnew = anim
anim_player.play(anim)

func input(event):
if (event.type==InputEvent.KEY and event.scancode == KEYUP and event.pressed):
anim = "Running"
animplayer.setspeed(0.5)
else:
anim = "IdlewithAnimGun"
animplayer.set_speed(0.2)
.
.
.
for another keys not working
any idea?

---

Done!

I changed else: per elif and it worked

func input(event):
if (event.type==InputEvent.KEY and event.scancode == KEY_UP and event.pressed):
anim = "Running"
animplayer.setspeed(0.6)

elif (event.type==InputEvent.KEY and event.scancode == KEYDOWN and event.pressed):
anim = "idlewithgunanim"
animplayer.setspeed(0.2)

elif (event.type==InputEvent.KEY and event.scancode == KEY_SPACE and event.pressed):
anim = "Running"
animplayer.setspeed(0.5)

Atemption now i used else for default animation

else:
anim = "default"
animplayer.setspeed(0.2)