Problem playing sound in Animation player

:information_source: Attention Topic was automatically imported from the old Question2Answer platform.
:bust_in_silhouette: Asked By Andrew Maher

I have area2d when a player enters it, it runs animation with sound and then queue free
the problem is that the animation won’t play nor the sound
Screenshot

Have you tried putting $AnimationPlayer.play("die") in the yield() function?

Ertain | 2019-12-11 08:56

:bust_in_silhouette: Reply From: OneGold88

We have a small guide about the PR workflow with some Git instructions: http://docs.godotengine.org/en/latest/community/contributing/pr_workflow.html

One problem is that you have a lot of redundant commits that fix your own code. Since those are pointless in the long history, we ask you to rebase onto a single commit (or a few relevant commits if that’s the case). Also it’s not passing the CI, so you need to fix the errors.

Other problem is that you are adding commented code. If those aren’t used you can simply remove them. You don’t even need to comment old code since those will be tracked by Git anyway.

If you don’t want to change your fork’s master branch, you can create another one and make a PR from that new branch so you can work in both branches separately. You might also want to split the bugfixes in a different PR since those are usually more interesting and easier to merge, then add the features on a new one so it can be reviewed for a longer time (if it’s not finished, it’s better if wait until it’s done before opening the PR).

:bust_in_silhouette: Reply From: andersmmg

Instead of controlling the playing property, you should use the audio player action. It’s in the + Add Track menu, second to last.